Fixes for #2408 and #2409. #2410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 9, 2021
| * @since 2.6 | ||
| */ | ||
| Iterable<? extends TypeInformation<?>> getPersistentEntityTypeInformation(); | ||
|
|
There was a problem hiding this comment.
The documentation is a bit confusing as it states the method to return null for a method thats return type is an Iterable. Wouldn't empty be a better fit?
There was a problem hiding this comment.
Good catch. Indeed, the Javadoc still stems from the times that the original method which the comment was copied from returned a single type, not a collection.
…nd Class on PersistentProperty. We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value. Fixes #2408.
…et type if available. This causes us to inspect the most concrete type we can find from a property declaration that might be overridden using an annotation. Fixes #2409.
christophstrobl
force-pushed
the
issue/2408-2409
branch
from
1a2b42f to
2fb449c
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Jul 13, 2021
…nd Class on PersistentProperty. We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value. Closes: #2408 Original Pull Request: #2410
christophstrobl
added a commit
that referenced
this pull request
Jul 13, 2021
Update documentation to match method signature. Original Pull Request: #2410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details. Needs spring-projects/spring-data-jpa#2255 and spring-projects/spring-data-mongodb#3701 merged, too.